Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Template for bug reporting, upgrade python version for codspeed #736

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

DeaMariaLeon
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

Python version upgraded so codspeed "Trace generation" is possible: https://docs.codspeed.io/features/trace-generation/

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change I missed in the last PR, otherwise is good to go.

Copy link

codspeed-hq bot commented Aug 6, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed πŸŽ‰

πŸ†• 1 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_matmul (2.6 ms)

@hameerabbasi hameerabbasi merged commit 3a68e73 into pydata:main Aug 6, 2024
18 of 19 checks passed
@hameerabbasi
Copy link
Collaborator

This is in, thanks @DeaMariaLeon!

@DeaMariaLeon DeaMariaLeon deleted the template branch August 6, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants